feat(services): support ipMode Proxy for LoadBalancer ingresses#2017
feat(services): support ipMode Proxy for LoadBalancer ingresses#20171fabi0 wants to merge 1 commit intocloudnativelabs:masterfrom
Conversation
|
I missed to stash a file after I changed it. I am going to correct that |
|
@1fabi0 Thanks for the contribution. It would be nice to be compliant with KEP-1860 and it looks like it wouldn't take too much to get there. From that point of view this PR looks pretty straight forward. However, it looks like we've changed underneath you so that your PR is no longer merge-able. Additionally, it looks like your work doesn't yet pass our linting and testing. If you could rebase your work on the current master branch, and then run |
5e20647 to
33d02d9
Compare
This implements support for KEP-1860. When a LoadBalancer ingress has ipMode set to 'Proxy', kube-router will skip adding the IP to the local IPVS table and will not hijack the traffic. If ipMode is 'VIP' or unset, the current behavior is maintained. Fixes cloudnativelabs#2014
33d02d9 to
421fd43
Compare
|
@aauren Thank you for the feedback! Since I don’t normally work with Go, I'm still getting used to the tooling. I missed the formatting step initially, which is why I did a couple of force pushes to fix it, I hope that’s alright. Also, make is showing me the following error: Thanks |
This implements support for KEP-1860. When a LoadBalancer ingress has ipMode set to 'Proxy', kube-router will skip adding the IP to the local IPVS table and will not hijack the traffic. If ipMode is 'VIP' or unset, the current behavior is maintained.
Fixes #2014